From 1f6051b3b3ec378a91fd294e1a20eb30f798119c Mon Sep 17 00:00:00 2001
From: wen ping <1425499266@qq.com>
Date: Wed, 20 Apr 2022 12:09:12 +0800
Subject: [PATCH] fix roarequest query parameters

---
 core/src/CommonClient.cc     | 2 +-
 test/core/commonclient_ut.cc | 8 +++++---
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/core/src/CommonClient.cc b/core/src/CommonClient.cc
index e17d2fd90..36fc646a2 100644
--- a/core/src/CommonClient.cc
+++ b/core/src/CommonClient.cc
@@ -125,7 +125,7 @@ CommonClient::buildRoaHttpRequest(const std::string &endpoint,
   url.setHost(endpoint);
   url.setPath(msg.resourcePath());
 
-  auto params = msg.headerParameters();
+  auto params = msg.queryParameters();
   std::map<std::string, std::string> queryParams;
   for (const auto &p : params) {
     if (!p.second.empty())
diff --git a/test/core/commonclient_ut.cc b/test/core/commonclient_ut.cc
index de44e7b62..512c0854c 100644
--- a/test/core/commonclient_ut.cc
+++ b/test/core/commonclient_ut.cc
@@ -1,7 +1,8 @@
 
+#include "gtest/gtest.h"
 #include <iostream>
 #include <stdio.h>
-#include "gtest/gtest.h"
+
 #include "alibabacloud/core/Utils.h"
 #include "alibabacloud/core/Config.h"
 #include "alibabacloud/core/AlibabaCloud.h"
@@ -117,7 +118,7 @@ namespace {
     HttpRequest rr = client->buildRoaHttpRequest("cn-shanghai", cr, HttpRequest::Method::Get);
     EXPECT_TRUE(rr.method() == HttpRequest::Method::Get);
     EXPECT_TRUE(rr.header("Accept") == "application/json");
-    EXPECT_TRUE(rr.url().toString() == "https://cn-shanghai/?header_k1=header_v1");
+    EXPECT_TRUE(rr.url().toString() == "https://cn-shanghai/?query_k1=query_v1");
     EXPECT_TRUE(rr.header("Host") == "cn-shanghai");
     // Wed, 09 Jan 2019 06:32:41 GMT
     string date = "Wed, 09 Jan 2019 06:32:41 GMT";
@@ -137,8 +138,9 @@ namespace {
     cr.setScheme("http");
     cr.setHeaderParameter("Accept", "test-accept");
     cr.setHeaderParameter("Content-Type", "test-content-type");
+    cr.setQueryParameter("query_key", "query_value");
     rr = client->buildRoaHttpRequest("cn-shanghai", cr, HttpRequest::Method::Get);
-    EXPECT_TRUE(rr.url().toString() == "http://cn-shanghai/?Accept=test-accept&Content-Type=test-content-type&header_k1=header_v1");
+    EXPECT_TRUE(rr.url().toString() == "http://cn-shanghai/?query_k1=query_v1&query_key=query_value");
     EXPECT_TRUE(rr.header("Accept") == "test-accept");
     EXPECT_TRUE(rr.header("Content-Type") == "test-content-type");